Add waiting for isChecked for DataViewsTest#2894
Conversation
labkey-tchad
left a comment
labkey-tchad
left a comment
There was a problem hiding this comment.
This doesn't seem related to the failure on TeamCity:
java.lang.AssertionError: Text 'Type:' was not present
at org.junit.Assert.fail(Assert.java:89)
at org.labkey.test.WebDriverWrapper.assertTextPresent(WebDriverWrapper.java:1731)
at org.labkey.test.WebDriverWrapper.assertTextPresent(WebDriverWrapper.java:1720)
at org.labkey.test.WebDriverWrapper.waitForText(WebDriverWrapper.java:2684)
at org.labkey.test.WebDriverWrapper.waitForText(WebDriverWrapper.java:2678)
at org.labkey.test.tests.DataViewsTest.refreshDateTest(DataViewsTest.java:302)
at org.labkey.test.tests.DataViewsTest.doVerifySteps(DataViewsTest.java:95)
at org.labkey.test.tests.StudyBaseTest.runUITests(StudyBaseTest.java:150)
at org.labkey.test.tests.StudyBaseTest.testSteps(StudyBaseTest.java:360)
Was this just an error you were hitting locally?
|
@labkey-tchad |
I definitely think it's worth making this more reliable for folks running the test locally. I was just commenting that rationale in the PR description isn't accurate. |
labkey-danield
left a comment
labkey-danield
left a comment
There was a problem hiding this comment.
Echoing what Trey said that I think it is worthwhile making this test more reliable when running locally.
I would check in this change, and let's see how it does on TeamCity.
If the failure is very infrequent, once every couple of months, I don't think it is worth spending any more time on it. There are other intermittent failures that happen more often, especially in the Apps, that would be better to investigate and fix.
3 participants
Rationale
Fix for test DataViewsTest.testSteps add waiting for isChecked